Markers
Table of Contents
ApiResponse.php
| Type | Line | Description |
|---|---|---|
| TODO | 144 | Handle as stream |
Client.php
| Type | Line | Description |
|---|---|---|
| TODO | 64 | Is it needed? |
| TODO | 69 | Is it needed? |
PubnubSubscription.php
| Type | Line | Description |
|---|---|---|
| TODO | 189 | Subscription renewal when everything will become async |
Client.php
| Type | Line | Description |
|---|---|---|
| TODO | 436 | Add more sink validation? |
Comment.php
| Type | Line | Description |
|---|---|---|
| TODO | 198 | Rename these to include "start". |
TokenStream.php
| Type | Line | Description |
|---|---|---|
| TODO | 233 | Handle non-space indentation |
AttributeEmulator.php
| Type | Line | Description |
|---|---|---|
| TODO | 35 | return $tokens; |
PrettyPrinterAbstract.php
| Type | Line | Description |
|---|---|---|
| TODO | 549 | Add <?php properly |
| TODO | 780 | Try to preserve formatting |
| TODO | 831 | Preserve formatting. |
| TODO | 941 | Preserve formatting. |
| TODO | 964 | Support removing single node. |
| TODO | 1428 | "yield" where both key and value are inserted doesn't work |
| TODO | 1457 | 'Stmt_TryCatch->finally' => [null, false, ' ', null], |
| TODO | 1475 | These need to be treated more carefully |
| TODO | 1572 | Insertion into empty statement lists. |
| TODO | 1646 | ]; |
SubscribeCallback.php
| Type | Line | Description |
|---|---|---|
| TODO | 17 | add annotation |
| TODO | 20 | add annotation |
SubscriptionManager.php
| Type | Line | Description |
|---|---|---|
| TODO | 83 | ensure this happens when an already established radio / connectivity is lost |
PNHistoryResult.php
| Type | Line | Description |
|---|---|---|
| TODO | 40 | $cipher refactoring |
SubscribeMessage.php
| Type | Line | Description |
|---|---|---|
| TODO | 44 | specify OriginationMetaData |
PubNubCryptoLegacy.php
| Type | Line | Description |
|---|---|---|
| TODO | 36 | handle non-encrypted unicode corner-case |
NegotiatorInterface.php
| Type | Line | Description |
|---|---|---|
| TODO | 9 | Look in to extension support |
| TODO | 46 | Consider extending this interface and moving this there. The spec does says the server can fail for this reason, but it is not a requirement. This is an implementation detail. |
RequestVerifier.php
| Type | Line | Description |
|---|---|---|
| TODO | 10 | Currently just returning invalid - should consider returning appropriate HTTP status code error #s |
| TODO | 76 | Once I fix HTTP::getHeaders just verify this isn't NULL or empty...or maybe need to verify it's a valid domain??? Or should it equal $_SERVER['HOST'] ? |
| TODO | 116 | The spec says we don't need to base64_decode - can I just check if the length is 24 and not decode? |
| TODO | 116 | Check the spec to see what the encoding of the key could be |
| TODO | 132 | Write logic for this method. See section 4.2.1.8 |
| TODO | 138 | Write logic for this method. See section 4.2.1.9 |
ServerNegotiator.php
| Type | Line | Description |
|---|---|---|
| TODO | 10 | Unicode: return mb_convert_encoding(pack("N",$u), mb_internal_encoding(), 'UCS-4BE'); |
| TODO | 159 | Consider extending this interface and moving this there. The spec does says the server can fail for this reason, but it is not a requirement. This is an implementation detail. |
FrameTest.php
| Type | Line | Description |
|---|---|---|
| TODO | 13 | getMaskingKey, getPayloadStartingByte don't have tests yet |
| TODO | 13 | Could use some clean up in general, I had to rush to fix a bug for a deadline, sorry. |
| TODO | 264 | Not yet testing when second additional payload length descriptor |
| TODO | 283 | I I wrote the dataProvider incorrectly, skipping for now |
| TODO | 303 | Move this test to bottom as it requires all methods of the class |
StreamEncryption.php
| Type | Line | Description |
|---|---|---|
| TODO | 66 | add write() event to make sure we're not sending any excessive data |
IdnaEncoder.php
| Type | Line | Description |
|---|---|---|
| TODO | 154 | Implement this based on RFC 3491 and the newer 5891 |
| TODO | 271 | this should also check if it's valid for a URL |